----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49530/#review140424 -----------------------------------------------------------
Ship it! src/slave/containerizer/mesos/isolators/gpu/isolator.hpp (line 133) <https://reviews.apache.org/r/49530/#comment205825> Need a little comment here that the key is a path, or perhaps just store Path from stout? ``` const map<Path, cgroups::devices::Entry> controlDeviceEntries; ``` - Benjamin Mahler On July 1, 2016, 8:17 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49530/ > ----------------------------------------------------------- > > (Updated July 1, 2016, 8:17 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-5764 > https://issues.apache.org/jira/browse/MESOS-5764 > > > Repository: mesos > > > Description > ------- > > As part of this, we also generalized the method for enumerating the > GPU control devices which should be accessible inside a container. > Now it should be easier to add new control devices as they appear in > the future. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/gpu/isolator.hpp > a6734105dcb3efadfceb7cdd357b749813a5bf40 > src/slave/containerizer/mesos/isolators/gpu/isolator.cpp > 2bf7fe2d9bff1afb1cb8ba5c401246e4579d8889 > > Diff: https://reviews.apache.org/r/49530/diff/ > > > Testing > ------- > > sudo GTEST_FILTER="*NVIDIA*" bin/mesos-tests.sh > > > Thanks, > > Kevin Klues > >
