> On July 1, 2016, 3:24 p.m., Jie Yu wrote: > > src/launcher/executor.cpp, lines 431-432 > > <https://reviews.apache.org/r/49389/diff/2/?file=1435272#file1435272line431> > > > > Hum, if `_check.isError()`, `checker->healthCheck()` below will abort. > > you should put `checker->healthCheck()` in else block
My bad! Fool mistake! - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49389/#review140444 ----------------------------------------------------------- On July 1, 2016, 4:33 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49389/ > ----------------------------------------------------------- > > (Updated July 1, 2016, 4:33 p.m.) > > > Review request for mesos, Anand Mazumdar, Benjamin Mahler, haosdent huang, > Artem Harutyunyan, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-5727 > https://issues.apache.org/jira/browse/MESOS-5727 > > > Repository: mesos > > > Description > ------- > > Refactored HealthCheck from a binary to be a library. > > > Diffs > ----- > > src/CMakeLists.txt 996d9e655b9d4343c07663fe840e94727cd792fe > src/Makefile.am 72f8a995f0a6373c0108900ff40395f698aa678e > src/health-check/health_checker.hpp PRE-CREATION > src/health-check/health_checker.cpp PRE-CREATION > src/health-check/main.cpp 4cc9dde8927acd4594477476f1b1bdc43963d789 > src/launcher/executor.cpp bb88a4570d183d22dff65f6e220d566c0924001a > > Diff: https://reviews.apache.org/r/49389/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
