----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49547/ -----------------------------------------------------------
Review request for mesos, Joseph Wu and Kevin Klues. Repository: mesos Description ------- Docker::run used Subprocess::PIPE as defaults for stdout and stderr, however the caller cannot obtain the read end of the pipe in order to read and avoid blocking the child. Also, internally these pipes are not read. This means the child process can block! For now, this changes the default to match stdout and stderr from the parent process. Ideally, we also prevent the caller from using Subprocess::PIPE since they cannot obtain the read end. Diffs ----- src/docker/docker.hpp 4343213391bb9a86e87410ce3a2c5d8447a1ab8d Diff: https://reviews.apache.org/r/49547/diff/ Testing ------- `make check GTEST_FILTER="*Docker*"` Thanks, Benjamin Mahler
