----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49501/#review140467 -----------------------------------------------------------
Ship it! LGTM! Tested this out locally. A couple minor nits noted below, which I'll fix before committing. src/CMakeLists.txt (line 260) <https://reviews.apache.org/r/49501/#comment205848> This file doesn't seem to exist anymore. I'll remove it. src/master/CMakeLists.txt (line 24) <https://reviews.apache.org/r/49501/#comment205850> This is already defined in `3rdparty/libprocess/cmake/Process3rdparyConfigure.cmake` as `MESOS_MASTER`. It is somewhat odd that mesos targets are defined in 3rdparty, but we can refactor that later. src/CMakeLists.txt (line 259) <https://reviews.apache.org/r/49501/#comment205853> This is already present at line 241. src/CMakeLists.txt (lines 271 - 273) <https://reviews.apache.org/r/49501/#comment205854> These are already present in lines 242-244. src/master/CMakeLists.txt (line 37) <https://reviews.apache.org/r/49501/#comment205852> Tried this out on Windows, but looks like there's a bit more work to be done there. I'll exclude the master from Win32 for now. - Joseph Wu On July 1, 2016, 5:37 p.m., Srinivas Brahmaroutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49501/ > ----------------------------------------------------------- > > (Updated July 1, 2016, 5:37 p.m.) > > > Review request for mesos, Alex Clemmer and Joseph Wu. > > > Bugs: MESOS-3541 > https://issues.apache.org/jira/browse/MESOS-3541 > > > Repository: mesos > > > Description > ------- > > Added cmake target to build mesos-master. > > > Diffs > ----- > > CMakeLists.txt c820dcd7d86de8e4896b96be6cc213be33de0d9b > cmake/MesosConfigure.cmake 09135380e558ce8834eb70e804fbd90472334160 > src/CMakeLists.txt 996d9e655b9d4343c07663fe840e94727cd792fe > src/master/CMakeLists.txt PRE-CREATION > src/master/cmake/MasterConfigure.cmake PRE-CREATION > > Diff: https://reviews.apache.org/r/49501/diff/ > > > Testing > ------- > > make mesos-master > mesos-master --help > > > Thanks, > > Srinivas Brahmaroutu > >
