> On July 2, 2016, 7:56 p.m., Kevin Klues wrote: > > 3rdparty/stout/include/stout/path.hpp, lines 255-261 > > <https://reviews.apache.org/r/49544/diff/1/?file=1435555#file1435555line255> > > > > Do we really need this function? It looks like just casting it to a > > string would be enough to turn it into a string?
Kevin and I chatted offline, mostly we avoid the convention of using an implicit cast (e.g. `(string) path`), so there are two options if leaving the cast operator: ``` string(path) // And stringify(path) ``` The latter tends to be used for printing purposes and the former is unconventional in our code base. Also, since we likely want to move towards <path> upcoming in the standard library, I followed the `.string()` convention from there. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49544/#review140503 ----------------------------------------------------------- On July 2, 2016, 12:46 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49544/ > ----------------------------------------------------------- > > (Updated July 2, 2016, 12:46 a.m.) > > > Review request for mesos and Kevin Klues. > > > Repository: mesos > > > Description > ------- > > This makes Path closer to boost's path, and more convenient to work with > (e.g. as map values, struct members, etc). > > > Diffs > ----- > > 3rdparty/stout/include/stout/path.hpp > 0ca13c6a1aebcb980c29dd33414bfa50c4b8bf81 > > Diff: https://reviews.apache.org/r/49544/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > >
