----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46825/#review140647 -----------------------------------------------------------
Patch looks great! Reviews applied: [46821, 46822, 46823, 46824, 46825] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On July 4, 2016, 8:17 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46825/ > ----------------------------------------------------------- > > (Updated July 4, 2016, 8:17 a.m.) > > > Review request for mesos, Alexander Rukletsov and Vinod Kone. > > > Bugs: MESOS-3335 > https://issues.apache.org/jira/browse/MESOS-3335 > > > Repository: mesos > > > Description > ------- > > Fully-typed all FlagsBase::add overloads. > > > Diffs > ----- > > 3rdparty/stout/include/stout/flags/flags.hpp > dd9362772d1fbd32638fc7e70126fd49d4a03c68 > 3rdparty/stout/tests/flags_tests.cpp > 77f3a6af110da1ffcdf2b7ab2b66431a6b5c91d3 > 3rdparty/stout/tests/subcommand_tests.cpp > 9213d6b9faec30b5be320ab37ca29c2406c964ac > > Diff: https://reviews.apache.org/r/46825/diff/ > > > Testing > ------- > > make check (OS X clang-trunk w/o optimizations) > > The mesos tests suite do not execute at all with an optimizing clang-trunk > since copying of the `map` inside `FlagsBase` reference random memory leading > to `SEGFAULTs`. With these patches all of `stout-tests` and > `libprocess-tests` can be executed, but some remaining failures persist in > `mesos-tests` (their number is reduced though). > > > Thanks, > > Benjamin Bannier > >
