> On July 4, 2016, 9:50 a.m., Guangya Liu wrote: > > src/launcher/windows/executor.cpp, lines 70-71 > > <https://reviews.apache.org/r/49425/diff/2/?file=1434267#file1434267line70> > > > > remove this
I think this TODO is still valid. I think os::stringify_args should just take a vector (or an iterable). - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49425/#review140637 ----------------------------------------------------------- On June 30, 2016, 4:18 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49425/ > ----------------------------------------------------------- > > (Updated June 30, 2016, 4:18 p.m.) > > > Review request for mesos and Joris Van Remoortere. > > > Repository: mesos > > > Description > ------- > > Used os::raw::Argv in command executor. > > > Diffs > ----- > > src/launcher/posix/executor.cpp ab1dd938a7c59f52b44aafe1340c614087460f84 > src/launcher/windows/executor.cpp f6da398eeddaf68b8eaf510648c55964d9f5b7c7 > > Diff: https://reviews.apache.org/r/49425/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
