> On July 2, 2016, 8:09 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/launch.cpp, lines 374-375 > > <https://reviews.apache.org/r/49473/diff/1/?file=1434483#file1434483line374> > > > > Also not yours. Could we fix the style here? Seems like from > > https://github.com/apache/mesos/commit/81e893d5cdb8a5873dd0c61ad7eceaa323aff466
This was fixed in the following patch. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49473/#review140505 ----------------------------------------------------------- On June 30, 2016, 9:22 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49473/ > ----------------------------------------------------------- > > (Updated June 30, 2016, 9:22 p.m.) > > > Review request for mesos, Benjamin Mahler, Gilbert Song, and Ian Downes. > > > Bugs: MESOS-5753 > https://issues.apache.org/jira/browse/MESOS-5753 > > > Repository: mesos > > > Description > ------- > > This is the first step allowing the command executor to directly use > `mesos-containerizer launch` to launch user task. The control pipe is > used to synchronize with the parent process. In the command executor, > this synchronization is not needed. Therefore, we make it optional. > > > Diffs > ----- > > src/slave/containerizer/mesos/launch.cpp > 83f4d7f28c066a605aa84862eca9fde900ec96c6 > > Diff: https://reviews.apache.org/r/49473/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
