> On July 4, 2016, 5:59 a.m., Gilbert Song wrote: > > src/slave/slave.cpp, line 3964 > > <https://reviews.apache.org/r/49540/diff/1/?file=1435481#file1435481line3964> > > > > Hmm.. seems like we dont have `mesos-executor` as the first argv for a > > while. Just curious that is not supposed to work correctly, right?
Because we used shell=true version previously. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49540/#review140608 ----------------------------------------------------------- On July 1, 2016, 11:24 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49540/ > ----------------------------------------------------------- > > (Updated July 1, 2016, 11:24 p.m.) > > > Review request for mesos, Gilbert Song, Ian Downes, and Vinod Kone. > > > Bugs: MESOS-5753 > https://issues.apache.org/jira/browse/MESOS-5753 > > > Repository: mesos > > > Description > ------- > > Used the argv version for command that launches the command executor. > > > Diffs > ----- > > src/slave/slave.cpp da643e6e50b2f313705d2f862c961291aa5d2f22 > src/tests/slave_tests.cpp d800cb8c10b5730a711c8354802bdff6aaca8c01 > > Diff: https://reviews.apache.org/r/49540/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
