> On July 4, 2016, 6:08 a.m., Gilbert Song wrote: > > src/launcher/executor.cpp, lines 664-701 > > <https://reviews.apache.org/r/49541/diff/1/?file=1435483#file1435483line664> > > > > This method was removed. Could you rebase?
yep. I'll rebase. > On July 4, 2016, 6:08 a.m., Gilbert Song wrote: > > src/launcher/executor.cpp, line 767 > > <https://reviews.apache.org/r/49541/diff/1/?file=1435483#file1435483line767> > > > > My bad. I should have remove this var on health check patches. Could > > you please just remove `healthCheckDir` and update the commit msg in this > > patch? Thanks. It was used later in the patch chain. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49541/#review140609 ----------------------------------------------------------- On July 1, 2016, 11:30 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49541/ > ----------------------------------------------------------- > > (Updated July 1, 2016, 11:30 p.m.) > > > Review request for mesos, Gilbert Song, Joris Van Remoortere, and Timothy > Chen. > > > Bugs: MESOS-5753 > https://issues.apache.org/jira/browse/MESOS-5753 > > > Repository: mesos > > > Description > ------- > > Renamed healthCheckDir to launcherDir in command executor. > > > Diffs > ----- > > src/launcher/executor.cpp bb88a4570d183d22dff65f6e220d566c0924001a > > Diff: https://reviews.apache.org/r/49541/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
