----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49308/#review140745 -----------------------------------------------------------
Yes, this is more like what I had in mind. - I would like to see you use authentication-specific flags/constants instead of registration_backoff_factor and REGISTER_RETRY_INTERVAL_MAX - How did you test this? src/slave/slave.cpp <https://reviews.apache.org/r/49308/#comment206107> Does your solution address this trickiness after a master failover? - Adam B On June 29, 2016, 12:08 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49308/ > ----------------------------------------------------------- > > (Updated June 29, 2016, 12:08 a.m.) > > > Review request for mesos, Adam B and Vinod Kone. > > > Bugs: MESOS-2043 > https://issues.apache.org/jira/browse/MESOS-2043 > > > Repository: mesos > > > Description > ------- > > The backoff follows to existing pattern for backoff used during agent > or scheduler registration where we backoff for some random time in an > interval of increasing length, capped by > `REGISTER_RETRY_INTERVAL_MAX`. > > > Diffs > ----- > > src/sched/sched.cpp 9f561d73a2e591afdc3ba4adb35a11763dced402 > src/slave/slave.hpp 2afd7d152dcd2f5390014cd7bd4e926b62c292d1 > src/slave/slave.cpp da643e6e50b2f313705d2f862c961291aa5d2f22 > > Diff: https://reviews.apache.org/r/49308/diff/ > > > Testing > ------- > > make check (OS X w/o optimizations). > > > Thanks, > > Benjamin Bannier > >
