----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49612/#review140790 -----------------------------------------------------------
Fix it, then Ship it! src/tests/hierarchical_allocator_tests.cpp <https://reviews.apache.org/r/49612/#comment206135> I would keep these 3 instances in this test. It's not immediately clear that `AWAIT` happens in `handleAllocationsAndRecoverResources()`. - Alexander Rukletsov On July 5, 2016, 8:51 a.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49612/ > ----------------------------------------------------------- > > (Updated July 5, 2016, 8:51 a.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Repository: mesos > > > Description > ------- > > If a test case calls `Clock::settle` and then immediately waits for a > future to be completed, settling the clock is usually unnecessary. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > 0498cd5e54b0e4b87a767585a77699653aa52179 > > Diff: https://reviews.apache.org/r/49612/diff/ > > > Testing > ------- > > `mesos-tests --gtest_filter=HierarchicalAllocatorTest.* --gtest_repeat=500 > --gtest_break_on_failure` > > > Thanks, > > Neil Conway > >
