> On July 5, 2016, 6:25 p.m., Vinod Kone wrote: > > src/master/master.cpp, lines 5013-5042 > > <https://reviews.apache.org/r/49607/diff/1/?file=1436499#file1436499line5013> > > > > I think we should change this as follows for clarity: > > > > ``` > > foreach (const FrameworkInfo& frameworkInfo, frameworks) { > > > > Framework* framework = getFramework(frameworkInfo.id()); > > > > if (framework != nullptr) { > > // Send UpdateFrameworkMessage > > } else { > > // Add it recovered map. > > } > > > > } > > > > ```
We cannot collapse the loops yet for backwards compatability (old agent, new master). I added a TODO to remove it after the deprecation cycle. - Joerg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49607/#review140833 ----------------------------------------------------------- On July 5, 2016, 8:15 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49607/ > ----------------------------------------------------------- > > (Updated July 5, 2016, 8:15 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Previously after a master failover while agents > were reregistering we might not have access > to all FrameworkInfo (which would first be available > once the Framework reregistered). This patch > adds support that once a framework reregisters > we also keep track of recovered FrameworkInfos. > > > Diffs > ----- > > src/master/master.hpp be7cd239c49a0710a29a8187c01484f9f6d615e1 > src/master/master.cpp 78a8889313179b4509a6657e6c61d9f6d3bb99c0 > src/messages/messages.proto 6d7eccc5501b3df010d981e09d0654e815da551f > src/slave/slave.cpp da643e6e50b2f313705d2f862c961291aa5d2f22 > > Diff: https://reviews.apache.org/r/49607/diff/ > > > Testing > ------- > > (sudo) make check > > > Thanks, > > Joerg Schad > >
