----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49518/#review140894 -----------------------------------------------------------
Looks very good! Just some minor style nit-picks. include/mesos/master/master.proto (line 443) <https://reviews.apache.org/r/49518/#comment206243> The part about this event being forwarded by the master looks redundant? How about making this consistent with similar comments in scheduler/executor.proto i.e. // First event received when a client subscribes. src/master/http.cpp (line 598) <https://reviews.apache.org/r/49518/#comment206250> s/executod/executed s/Note/NOTE Also, this looks more like a TODO than a NOTE? src/tests/api_tests.cpp (lines 1424 - 1425) <https://reviews.apache.org/r/49518/#comment206245> Capture alias by const ref? src/tests/api_tests.cpp (lines 1427 - 1434) <https://reviews.apache.org/r/49518/#comment206244> Nit: These individual multi line statements should all fit in one line, no? src/tests/api_tests.cpp (lines 1433 - 1434) <https://reviews.apache.org/r/49518/#comment206253> Nit: Move this after L1428 to align with your comment i.e. expected 1 framework/agent followed by 0 tasks/executors. - Anand Mazumdar On July 5, 2016, 11:08 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49518/ > ----------------------------------------------------------- > > (Updated July 5, 2016, 11:08 p.m.) > > > Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone. > > > Bugs: MESOS-5498 > https://issues.apache.org/jira/browse/MESOS-5498 > > > Repository: mesos > > > Description > ------- > > Initial snapshot for v1 master event stream. > > > Diffs > ----- > > include/mesos/master/master.proto d06258e9fd39c7eefd8ecd394e3bdfb888479b1e > include/mesos/v1/master/master.proto > b7cb6fdf2e4f34a11d326ac3ad3ec26525f8f343 > src/master/http.cpp 7b2f77b9264242f31ab62eb9db7c621a1b8aa2fe > src/tests/api_tests.cpp e2d8bf591667ec9d8c609e55a424b55561892b5f > > Diff: https://reviews.apache.org/r/49518/diff/ > > > Testing > ------- > > Updated test and make check. > > > Thanks, > > Zhitao Li > >
