----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49517/#review140901 -----------------------------------------------------------
Fix it, then Ship it! Some minor style nits. Also if you have not done so, can you run this test with `gtest_repeat=100` to be sure that it's not flaky? src/master/http.cpp (line 1537) <https://reviews.apache.org/r/49517/#comment206255> 2 space indent here for continuations please like you do in a later function in this change. src/master/http.cpp (line 1538) <https://reviews.apache.org/r/49517/#comment206266> 2 space indent here before `->` src/master/http.cpp (line 1550) <https://reviews.apache.org/r/49517/#comment206267> pass argument by const ref. Ditto for the declaration in header src/master/http.cpp (line 1558) <https://reviews.apache.org/r/49517/#comment206265> Do you need to capture anything here? src/tests/api_tests.cpp (line 453) <https://reviews.apache.org/r/49517/#comment206268> Remove this. We tend to avoid being explicit about `Times(1)`. src/tests/api_tests.cpp (line 467) <https://reviews.apache.org/r/49517/#comment206262> Extra space. src/tests/api_tests.cpp (line 474) <https://reviews.apache.org/r/49517/#comment206263> New line before and capture by const ref. src/tests/api_tests.cpp (lines 477 - 478) <https://reviews.apache.org/r/49517/#comment206264> Reorder expectation based on comment earlier. src/tests/api_tests.cpp (lines 481 - 489) <https://reviews.apache.org/r/49517/#comment206261> Let's be less verbose and just use: `createTask(offer, "", DEFAULT_EXECUTOR_ID)` src/tests/api_tests.cpp (line 517) <https://reviews.apache.org/r/49517/#comment206260> Newline before and capture by const ref? src/tests/api_tests.cpp (line 537) <https://reviews.apache.org/r/49517/#comment206269> Just execDriver->sendXX would suffice. Would be a good idea to do a sweep across this file and remove the redundant `get()` in favor of the `->` operator. src/tests/api_tests.cpp (line 552) <https://reviews.apache.org/r/49517/#comment206258> Newline before + capture by const ref? - Anand Mazumdar On July 4, 2016, 4:05 a.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49517/ > ----------------------------------------------------------- > > (Updated July 4, 2016, 4:05 a.m.) > > > Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone. > > > Bugs: MESOS-5489 > https://issues.apache.org/jira/browse/MESOS-5489 > > > Repository: mesos > > > Description > ------- > > The help function will also be used for snapshot of > event stream. > > > Diffs > ----- > > src/master/http.cpp 7b2f77b9264242f31ab62eb9db7c621a1b8aa2fe > src/master/master.hpp be7cd239c49a0710a29a8187c01484f9f6d615e1 > src/tests/api_tests.cpp e2d8bf591667ec9d8c609e55a424b55561892b5f > > Diff: https://reviews.apache.org/r/49517/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Zhitao Li > >
