----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49658/#review140913 -----------------------------------------------------------
Ship it! Ship It! - Benjamin Mahler On July 5, 2016, 9:25 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49658/ > ----------------------------------------------------------- > > (Updated July 5, 2016, 9:25 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-5767 > https://issues.apache.org/jira/browse/MESOS-5767 > > > Repository: mesos > > > Description > ------- > > The previous patch incorrectly fixed the alignment of an ELF note to 4 > bytes (even for 64 bit ELF files). This happened to be OK for our > specific case of parsing '.note.ABI-tag' sections. However, the > alignment for notes in a 64 bit ELF section should be 8-byte aligned > (as the original code attempts to do). The problem with the original > code, however, is that it performs the alignment only on the name > string inside the note, rather than the entire note object itself. > This commit fixes this alignment issue. > > > Diffs > ----- > > 3rdparty/elfio-3.1.patch f8c20e92a0ec12e8a2f1d8e8ec54eac78ced707d > > Diff: https://reviews.apache.org/r/49658/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Kevin Klues > >
