> On July 6, 2016, 10:20 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 1054 > > <https://reviews.apache.org/r/49650/diff/1/?file=1437219#file1437219line1054> > > > > Please add a check on `DESTROYING` state, otherwise it may cost a race > > if destroy while fetching. > > > > ``` > > if (containers_[containerId]->state == DESTROYING) { > > return Failure("Container is currently being destroyed"); > > } > > ``` > > Jiang Yan Xu wrote: > It's in /r/49653/, for this patch I wanted to focus on fixing what > directly broke the container destroy path when the fetcher is stuck. > > Jiang Yan Xu wrote: > Well, I guess I can move it over as well since /r/49653/ focuses on error > messages.
Thanks:) - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49650/#review141029 ----------------------------------------------------------- On July 6, 2016, 10:07 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49650/ > ----------------------------------------------------------- > > (Updated July 6, 2016, 10:07 a.m.) > > > Review request for mesos, Jie Yu and Vinod Kone. > > > Bugs: MESOS-5763 > https://issues.apache.org/jira/browse/MESOS-5763 > > > Repository: mesos > > > Description > ------- > > If the container state is not properly set to FETCHING, Mesos agent > cannot detect the terminated executor when the fetcher times out. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > f53b01b0eef8dd24db28d9dbd86bcbd40dc8d17f > > Diff: https://reviews.apache.org/r/49650/diff/ > > > Testing > ------- > > make check. > > Also with an experimental setup using mesos-execute with an agent with a fake > hadoop binary that sleeps forever. The task is transitioned to LOST if the > executor fetching times out; without the patch the task is stuck in STAGING. > > Megha will submit a code test for this soon. > > > Thanks, > > Jiang Yan Xu > >
