> On July 7, 2016, 5:20 p.m., Zhitao Li wrote: > > src/slave/http.cpp, line 1032 > > <https://reviews.apache.org/r/49757/diff/1/?file=1438711#file1438711line1032> > > > > nit: capture `[this, contentType]` > > Abhishek Dasgupta wrote: > Then we don't need defer(slave->self() as well..
please, ignore my earlier comment. - Abhishek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49757/#review141180 ----------------------------------------------------------- On July 7, 2016, 2:59 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49757/ > ----------------------------------------------------------- > > (Updated July 7, 2016, 2:59 p.m.) > > > Review request for mesos, Anand Mazumdar, Vinod Kone, and Zhitao Li. > > > Repository: mesos > > > Description > ------- > > Implemented 'GetFrameworks' call in v1 agent API. > > > Diffs > ----- > > include/mesos/agent/agent.proto 538d12f71df1943f91bafb99650625aa910affaa > include/mesos/v1/agent/agent.proto 48f15173fe62b9ce7f648f6b54d74ec62f797c55 > src/slave/http.cpp ef2d510b86e5d4f731c2ea6b7df8246a0be9d812 > src/slave/slave.hpp 6a82c365baf463db298bfcc4771d9f6109b9f4bc > src/slave/validation.cpp b07e80a5e0b7d6cd383cf2d9914b8c83f740770d > > Diff: https://reviews.apache.org/r/49757/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
