----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49520/#review141302 -----------------------------------------------------------
Fix it, then Ship it! src/tests/gc_tests.cpp (line 899) <https://reviews.apache.org/r/49520/#comment206769> We don't need to name it `_mountPoint` anymore now that we don't have the test fixture's member variable `mountPoint`. I'll clean it up when committing. - Jiang Yan Xu On July 8, 2016, 10:29 a.m., Megha Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49520/ > ----------------------------------------------------------- > > (Updated July 8, 2016, 10:29 a.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-5752 > https://issues.apache.org/jira/browse/MESOS-5752 > > > Repository: mesos > > > Description > ------- > > In GarbageCollectorIntegrationTest.BusyMountPoint there is > a race between the task creating a file and the test looking for it > which sometimes leads to assertion failure on the existence of the > file. > > > Diffs > ----- > > src/tests/gc_tests.cpp d6335dc711f0697a0728a912e713cf1ed783c146 > > Diff: https://reviews.apache.org/r/49520/diff/ > > > Testing > ------- > > make check on mac os and linux for 50 iterations and verified the temp > directory is cleaned up after the test. > > > Thanks, > > Megha Sharma > >
