----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49796/#review141319 -----------------------------------------------------------
src/files/files.cpp (lines 512 - 513) <https://reviews.apache.org/r/49796/#comment206816> Can we make the error message similar to the negative length one for consistency? - Anand Mazumdar On July 8, 2016, 6:58 p.m., zhou xing wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49796/ > ----------------------------------------------------------- > > (Updated July 8, 2016, 6:58 p.m.) > > > Review request for mesos and Anand Mazumdar. > > > Bugs: mesos-5515 > https://issues.apache.org/jira/browse/mesos-5515 > > > Repository: mesos > > > Description > ------- > > Added negative number check for read_file offset parameter in > files.cpp. > > > Diffs > ----- > > src/files/files.cpp c8991c4ffcddc2c196d96cdfec104cd7a87aac34 > > Diff: https://reviews.apache.org/r/49796/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > zhou xing > >
