> On July 6, 2016, 3:46 p.m., Benjamin Mahler wrote: > > You also need to disable the tests in this patch now, yes?
Yup. Added. > On July 6, 2016, 3:46 p.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/src/tests/test_linkee.cpp, line 41 > > <https://reviews.apache.org/r/49543/diff/1/?file=1435517#file1435517line41> > > > > No static non-PODs, can you use a pointer and 'new' it? Since it doesn't make much of a difference to store or leak `Socket*`, I opted to leak the pointers directly. With a comment, of course. > On July 6, 2016, 3:46 p.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/src/tests/test_linkee.cpp, line 160 > > <https://reviews.apache.org/r/49543/diff/1/?file=1435517#file1435517line160> > > > > You shouldn't need to do this since Try allows non-const access: > > `outgoing->send` I was missing a `mutable` in the lambda surrounding this statement. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49543/#review141093 ----------------------------------------------------------- On July 8, 2016, 2:25 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49543/ > ----------------------------------------------------------- > > (Updated July 8, 2016, 2:25 p.m.) > > > Review request for mesos, Benjamin Mahler and Artem Harutyunyan. > > > Bugs: MESOS-5759 > https://issues.apache.org/jira/browse/MESOS-5759 > > > Repository: mesos > > > Description > ------- > > The ProcessRemoteLinkTests `RemoteUseStaleLink` and > `RemoteStaleLinkRelink` were failing because the `test-linkee` was > closing sockets shortly after the test `::shutdown` the link. This > is the expected behavior of libprocess. > > Rewrites the `test-linkee` to keep all sockets open, regardless of the > state of the connection. And re-enables the tests. > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/process_tests.cpp > 54d9bbbd112668f27e572c38010cfab0707587a3 > 3rdparty/libprocess/src/tests/test_linkee.cpp > 7ba0f4833a5163d2323e1477509fd2fbacc23690 > > Diff: https://reviews.apache.org/r/49543/diff/ > > > Testing > ------- > > make check (CentOS 7) > > 3rdparty/libprocess/libprocess-tests --gtest_filter="ProcessRemoteLinkTest*" > --gtest_break_on_failure --gtest_repeat=10000 > > > Thanks, > > Joseph Wu > >
