----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35234/#review141479 -----------------------------------------------------------
Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md) for reopening reviews. - Joris Van Remoortere On Aug. 26, 2015, 8:09 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35234/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2015, 8:09 p.m.) > > > Review request for mesos, Benjamin Hindman, Cody Maloney, and Timothy St. > Clair. > > > Bugs: MESOS-2537 > https://issues.apache.org/jira/browse/MESOS-2537 > > > Repository: mesos > > > Description > ------- > > Let both --enable-$OPTION and --disable-$OPTION work consistently. > Add bundled package options consistent with Mesos, so that options > passed down from Mesos work correctly. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am > eb34251d24b1e5d1540151b59cf1062ca85aeb03 > 3rdparty/libprocess/configure.ac 7c2bcffe5c7be1f7d90e6df470d20a00245bfbff > > Diff: https://reviews.apache.org/r/35234/diff/ > > > Testing > ------- > > Make and make check on CentOS 7 and OS X. There's definitely combinations > that have not been tested! > > Note that this removes some login around using gmock. AFAICT the unbundled > gmock doesn't work in the general case. I have a bunch of crashes where the > build would pick up gtest headers from the system and gmock from libprocess > 3rdparty. My conclusion is that the only safe path is to use the bundled > gmock. There's no real path through the build to use decoupled gmock and > gtest, it seems to be assumed that gmock will provide gtest. > > > Thanks, > > James Peach > >
