----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49819/#review141613 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 327) <https://reviews.apache.org/r/49819/#comment206953> s/Prepare hierarchy/Create cgroup/ src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 330) <https://reviews.apache.org/r/49819/#comment206955> s/`_createCgroup`/`create`/ src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 331) <https://reviews.apache.org/r/49819/#comment206954> A new line after this line. src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (lines 346 - 351) <https://reviews.apache.org/r/49819/#comment206956> Suggest to change to: ``` return collect(prepares) .then(defer( PID<CgroupsIsolatorProcess>(this), &CgroupsIsolatorProcess::_prepare, containerId, containerConfig, lambda::_1)); ``` src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 362) <https://reviews.apache.org/r/49819/#comment206958> I do not think you need to call `cleanup()` here. If the prepare fails, each isolator's `cleanup()` will already be called by Mesos containerizer. src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (lines 377 - 387) <https://reviews.apache.org/r/49819/#comment206960> I do not think we need this method for the same reason that I mentioned in my last comment. - Qian Zhang On July 9, 2016, 6:16 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49819/ > ----------------------------------------------------------- > > (Updated July 9, 2016, 6:16 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. > > > Repository: mesos > > > Description > ------- > > Implemented `CgroupsIsolatorProcess::prepare`. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/49819/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
