> On July 11, 2016, 4:31 p.m., Neil Conway wrote: > > src/slave/slave.cpp, line 4778 > > <https://reviews.apache.org/r/48313/diff/6/?file=1435277#file1435277line4778> > > > > Should we also remove the target resources in the case when target and > > checkpointed resources are the same?
Yes, you are right. We should since we do not need the target resources in either case. > On July 11, 2016, 4:31 p.m., Neil Conway wrote: > > src/slave/state.cpp, line 712 > > <https://reviews.apache.org/r/48313/diff/6/?file=1435279#file1435279line712> > > > > Can we avoid reusing the same variable name? How about `infoPath` and > > `targetPath`? Actually, I consolidated the 2 variables into `path` based on a previous comment but I think keeping them separate make following the code easier. - Anindya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48313/#review141657 ----------------------------------------------------------- On July 1, 2016, 9:39 p.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48313/ > ----------------------------------------------------------- > > (Updated July 1, 2016, 9:39 p.m.) > > > Review request for mesos, Neil Conway and Jiang Yan Xu. > > > Bugs: MESOS-5448 > https://issues.apache.org/jira/browse/MESOS-5448 > > > Repository: mesos > > > Description > ------- > > When the agent receives CheckpointedResourcesMessage, we store the > target checkpoint on disk. On successful create and destroy of > persistent volumes as a part of handling this messages, we commit > the checkpoint on the disk, and clear the target checkpoint. > > However, incase of any failure we do not commit the checkpoint to > disk, and exit the agent. When the agent restarts and there is a > target checkpoint present on disk which differs from the committed > checkpoint, we retry to sync the target and committed checkpoint. > On success, we reregister the agent with the master, but in case it > fails, we do not commit the checkpoint and the agent exists. > > > Diffs > ----- > > src/slave/paths.hpp 339e539863c678b6ed4d4670d75c7ff4c54daa79 > src/slave/paths.cpp 03157f93b1e703006f95ef6d0a30afae375dcdb5 > src/slave/slave.hpp 484ba758b4c87935aabd2f76a0e654a3c6d09167 > src/slave/slave.cpp da643e6e50b2f313705d2f862c961291aa5d2f22 > src/slave/state.hpp 0de2a4ee4fabaad612c4526166157b001c380bdb > src/slave/state.cpp 9cec0868b1187ed3ccac7f065e8a21c2f52178d9 > > Diff: https://reviews.apache.org/r/48313/diff/ > > > Testing > ------- > > All tests passed. > > > Thanks, > > Anindya Sinha > >
