----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49928/#review141801 -----------------------------------------------------------
Ship it! Confirmed that this regenerates the proper protobufs upon detecting a change. - Joseph Wu On July 11, 2016, 3 p.m., Srinivas Brahmaroutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49928/ > ----------------------------------------------------------- > > (Updated July 11, 2016, 3 p.m.) > > > Review request for mesos, Anand Mazumdar, Alex Clemmer, and Joseph Wu. > > > Bugs: MESOS-5756 > https://issues.apache.org/jira/browse/MESOS-5756 > > > Repository: mesos > > > Description > ------- > > Fixed dependency on .proto sources to generate protobufs. > > > Diffs > ----- > > src/cmake/MesosProtobuf.cmake 273d74df581d85b9ef08a533c6ad8e31a23f1417 > > Diff: https://reviews.apache.org/r/49928/diff/ > > > Testing > ------- > > cmake .. && make > Changed a .proto source and see if that triggered recompilation of the proto > and the relevant cpp files that depende on this corresponding .cc file. > > > Thanks, > > Srinivas Brahmaroutu > >
