> On July 8, 2016, 12:11 p.m., Jay Guo wrote: > > src/slave/http.cpp, lines 1240-1261 > > <https://reviews.apache.org/r/49759/diff/2/?file=1439598#file1439598line1240> > > > > @zhitao and I once had a conversation to create a helper function to > > create approvers, which can be used by many methods we had. He had a patch > > here: https://reviews.apache.org/r/49130/ I wonder if we could still have > > it.
@guoer I saw the patch have already discarded. I think we could update it together if want to refactor this helper functions in the future. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49759/#review141277 ----------------------------------------------------------- On July 8, 2016, 10:24 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49759/ > ----------------------------------------------------------- > > (Updated July 8, 2016, 10:24 a.m.) > > > Review request for mesos, Anand Mazumdar, Vinod Kone, and Zhitao Li. > > > Repository: mesos > > > Description > ------- > > Implemented 'GetTasks' call in v1 agent API. > > > Diffs > ----- > > include/mesos/agent/agent.proto ef07b1f0668dca9dcebc898cfc6caf5680b24016 > include/mesos/v1/agent/agent.proto 8f845081d504cd045677a65f7dea7429472c5bbc > src/slave/http.cpp 86803fe5c6524ada01956840e90404ab176ff8fb > src/slave/slave.hpp a8952f00086c8feb486895eb6a41cc2d27432da0 > src/slave/validation.cpp b07e80a5e0b7d6cd383cf2d9914b8c83f740770d > > Diff: https://reviews.apache.org/r/49759/diff/ > > > Testing > ------- > > Test case is https://reviews.apache.org/r/49799/ > > > Thanks, > > haosdent huang > >
