----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49874/#review141849 -----------------------------------------------------------
src/slave/CMakeLists.txt (lines 24 - 29) <https://reviews.apache.org/r/49874/#comment207249> So, what's the reason this is here? All the libraries and binaries have their own `CMakeLists.txt` (see, _e.g._, `src/health-check/CMakeLists.txt`, _etc._). Is there any advantage to not adhering to this pattern here? src/slave/cmake/SlaveConfigure.cmake (line 19) <https://reviews.apache.org/r/49874/#comment207247> This is meant to be the target name, right? If so, this should probably be a `CACHE STRING` as the other targets are. In addition, this should probably go with all the other agent targets, in `Process3rdpartyConfigure.cmake`. If this seems like an odd place to do this -- yes, it is. We should never have put these here, but they're there now, so please put this with those and leave a `TODO(hausdorff)` for me to clean that up. And, sorry about that. - Alex Clemmer On July 11, 2016, 8:42 p.m., Srinivas Brahmaroutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49874/ > ----------------------------------------------------------- > > (Updated July 11, 2016, 8:42 p.m.) > > > Review request for mesos, Alex Clemmer and Joseph Wu. > > > Bugs: MESOS-5792 > https://issues.apache.org/jira/browse/MESOS-5792 > > > Repository: mesos > > > Description > ------- > > Added logrotate_container_logger for running mesos tests. > > > Diffs > ----- > > src/slave/CMakeLists.txt d31440cb5e784d3e4f1236ac45001e80384f36f6 > src/slave/cmake/SlaveConfigure.cmake > ca4575653e00e8f868160976344ac1d57b5f7d27 > > Diff: https://reviews.apache.org/r/49874/diff/ > > > Testing > ------- > > cmake .. && make > > > Thanks, > > Srinivas Brahmaroutu > >
