> On July 12, 2016, 8:27 a.m., Alexander Rukletsov wrote: > > src/common/resources.cpp, lines 1486-1488 > > <https://reviews.apache.org/r/49910/diff/1/?file=1441434#file1441434line1486> > > > > Let's add the default case as well (see e.g. how `Resource` is printed).
Not sure adding a default case is the way to go. At least lately we have move away from it. The reason being, if we add more elements to the ENUM and there is a default case, we wont get neither a warning nor a compulation error if it is not handled in every `switch`. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49910/#review141858 ----------------------------------------------------------- On July 12, 2016, 8:15 a.m., Tim Harper wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49910/ > ----------------------------------------------------------- > > (Updated July 12, 2016, 8:15 a.m.) > > > Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Joseph Wu. > > > Bugs: MESOS-5824 > https://issues.apache.org/jira/browse/MESOS-5824 > > > Repository: mesos > > > Description > ------- > > Output disk resource source information. > > > Diffs > ----- > > src/common/resources.cpp cf07072 > > Diff: https://reviews.apache.org/r/49910/diff/ > > > Testing > ------- > > I ran `make check` in my OS X build environment. I had to disable SVN tests > because they didn't work, but I doubt this affected that feature set. > > Resolves [MESOS-5824](https://issues.apache.org/jira/browse/MESOS-5824) > > > Thanks, > > Tim Harper > >
