----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49958/#review141962 -----------------------------------------------------------
The patch LGTM! Thanks! Will come back with a Ship it. src/docker/docker.cpp (lines 620 - 631) <https://reviews.apache.org/r/49958/#comment207407> Should we consider just deprecate `DockerInfo.volume_driver` in this patch? Since 1.0 will be released these couple days. src/tests/containerizer/docker_tests.cpp (lines 843 - 875) <https://reviews.apache.org/r/49958/#comment207406> We dont need this test since `volume_driver` in DockerInfo will be deprecated soon. - Gilbert Song On July 12, 2016, 10:04 a.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49958/ > ----------------------------------------------------------- > > (Updated July 12, 2016, 10:04 a.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-5834 > https://issues.apache.org/jira/browse/MESOS-5834 > > > Repository: mesos > > > Description > ------- > > This fix prevents the Docker containerizer from specifying > --volume_driver multiple times. > > > Diffs > ----- > > src/docker/docker.cpp aad5380f5848f1b49d5524032f3b5b18c2aa1c56 > src/tests/containerizer/docker_tests.cpp > 00ccc2fc54a984f3a67573ce6fe7aee3e60ce3a2 > > Diff: https://reviews.apache.org/r/49958/diff/ > > > Testing > ------- > > Added two new tests and they pass. > > > Thanks, > > Gastón Kleiman > >
