> On July 11, 2016, 9:32 p.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 3196 > > <https://reviews.apache.org/r/49784/diff/1/?file=1439341#file1439341line3196> > > > > Two issues for this patch: > > > > 1) The new added framework number will introduce some cases that agent > > number is less than framework number and some frameworks may not able to > > get resources. > > 2) This will slow down the unit test, it is better introduce this and > > fix https://issues.apache.org/jira/browse/MESOS-4558 together by > > introducing `batchsize` for benchmark test. > > Alexander Rukletsov wrote: > 1) I think this a good thing to test / benchmark. > 2) Benchmark tests are not part of the default test suite, hence it seems > fine if this test takes more time to run. > > Guangya Liu wrote: > For 2), one minor comment is MESOS-4558 is tracking the time of benchmark > tests because want to enable them on ASF CI, so it is better to reduce the > time of the benchmark test.
I commented on MESOS-4558. For this patch I think this is fine because speeding up benchmark tests (or just CI) isn't necessarily at odds with increasing the cluster size. The motivation for the latter is that we do have this many frameworks in our cluster and we'd like to test it. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49784/#review141843 ----------------------------------------------------------- On July 7, 2016, 9:02 p.m., Jacob Janco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49784/ > ----------------------------------------------------------- > > (Updated July 7, 2016, 9:02 p.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-5780 and MESOS-5781 > https://issues.apache.org/jira/browse/MESOS-5780 > https://issues.apache.org/jira/browse/MESOS-5781 > > > Repository: mesos > > > Description > ------- > > - Our clusters have very high numbers of frameworks, > and we would like to increase the allocator benchmark > parameters to reflect this. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > 0498cd5e54b0e4b87a767585a77699653aa52179 > > Diff: https://reviews.apache.org/r/49784/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jacob Janco > >
