----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49381/#review142069 -----------------------------------------------------------
Patch looks great! Reviews applied: [49381] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On July 13, 2016, 1:48 p.m., Klaus Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49381/ > ----------------------------------------------------------- > > (Updated July 13, 2016, 1:48 p.m.) > > > Review request for mesos, Benjamin Mahler, Guangya Liu, and Michael Park. > > > Bugs: MESOS-5700 > https://issues.apache.org/jira/browse/MESOS-5700 > > > Repository: mesos > > > Description > ------- > > Benchmark for Resources class. > > > Diffs > ----- > > src/tests/resources_tests.cpp dc12bd8f1e2da6972bc8aed598811c55d664036e > > Diff: https://reviews.apache.org/r/49381/diff/ > > > Testing > ------- > > make > MESOS_BENCHMARK=1 GTEST_FILTER="*Resources_BENCHMARK_Test.Operator*" make > check > > [----------] Global test environment set-up. > [----------] 30 tests from ResourcesOperators/Resources_BENCHMARK_Test > [ RUN ] > ResourcesOperators/Resources_BENCHMARK_Test.Operator_AddAndAssign/0 > Took 5429us to `AddAndAssign` "cpus:1" 10000 times. > [ OK ] > ResourcesOperators/Resources_BENCHMARK_Test.Operator_AddAndAssign/0 (6 ms) > [ RUN ] > ResourcesOperators/Resources_BENCHMARK_Test.Operator_AddAndAssign/1 > Took 9317us to `AddAndAssign` "cpus:1;mem:2" 10000 times. > [ OK ] > ResourcesOperators/Resources_BENCHMARK_Test.Operator_AddAndAssign/1 (10 ms) > [ RUN ] > ResourcesOperators/Resources_BENCHMARK_Test.Operator_AddAndAssign/2 > **Took 5.271509secs to `AddAndAssign` "cpus(r0):1;cpus(r1):1; ... > cpus(r99):1" 10000 times.** > [ OK ] > ResourcesOperators/Resources_BENCHMARK_Test.Operator_AddAndAssign/2 (5271 ms) > [ RUN ] > ResourcesOperators/Resources_BENCHMARK_Test.Operator_AddAndAssign/3 > **Took 13.017557secs to `AddAndAssign` "cpus(r0):1;mem(r0):100; ... > cpus(r99):1;mem(r99):100" 10000 times.** > [ OK ] > ResourcesOperators/Resources_BENCHMARK_Test.Operator_AddAndAssign/3 (13018 ms) > [ RUN ] > ResourcesOperators/Resources_BENCHMARK_Test.Operator_AddAndAssign/4 > **Took 3.357184secs to `AddAndAssign` "[1-2, 4-5, ... , 298-299]" 10000 > times.** > [ OK ] > ResourcesOperators/Resources_BENCHMARK_Test.Operator_AddAndAssign/4 (3358 ms) > [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Add/0 > Took 20977us to `Add` "cpus:1" 10000 times. > [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Add/0 (21 > ms) > [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Add/1 > Took 26069us to `Add` "cpus:1;mem:2" 10000 times. > [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Add/1 (26 > ms) > [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Add/2 > **Took 5.891177secs to `Add` "cpus(r0):1;cpus(r1):1; ... cpus(r99):1" 10000 > times.** > [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Add/2 (5891 > ms) > [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Add/3 > **Took 14.894299secs to `Add` "cpus(r0):1;mem(r0):100; ... > cpus(r99):1;mem(r99):100" 10000 times.** > [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Add/3 > (14895 ms) > [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Add/4 > **Took 2.321527secs to `Add` "[1-2, 4-5, ... , 298-299]" 10000 times.** > [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Add/4 (2321 > ms) > [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Sub/0 > Took 26362us to `Sub` "cpus:1" 10000 times. > [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Sub/0 (27 > ms) > [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Sub/1 > Took 30828us to `Sub` "cpus:1;mem:2" 10000 times. > [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Sub/1 (31 > ms) > [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Sub/2 > Took 431531us to `Sub` "cpus(r0):1;cpus(r1):1; ... cpus(r99):1" 10000 times. > [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Sub/2 (431 > ms) > [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Sub/3 > Took 837827us to `Sub` "cpus(r0):1;mem(r0):100; ... cpus(r99):1;mem(r99):100" > 10000 times. > [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Sub/3 (838 > ms) > [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Sub/4 > **Took 2.173558secs to `Sub` "[1-2, 4-5, ... , 298-299]" 10000 times.** > [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_Sub/4 (2174 > ms) > [ RUN ] > ResourcesOperators/Resources_BENCHMARK_Test.Operator_SubAndAssign/0 > Took 3536us to `SubAndAssign` "cpus:1" 10000 times. > [ OK ] > ResourcesOperators/Resources_BENCHMARK_Test.Operator_SubAndAssign/0 (4 ms) > [ RUN ] > ResourcesOperators/Resources_BENCHMARK_Test.Operator_SubAndAssign/1 > Took 6091us to `SubAndAssign` "cpus:1;mem:2" 10000 times. > [ OK ] > ResourcesOperators/Resources_BENCHMARK_Test.Operator_SubAndAssign/1 (6 ms) > [ RUN ] > ResourcesOperators/Resources_BENCHMARK_Test.Operator_SubAndAssign/2 > Took 399855us to `SubAndAssign` "cpus(r0):1;cpus(r1):1; ... cpus(r99):1" > 10000 times. > [ OK ] > ResourcesOperators/Resources_BENCHMARK_Test.Operator_SubAndAssign/2 (400 ms) > [ RUN ] > ResourcesOperators/Resources_BENCHMARK_Test.Operator_SubAndAssign/3 > Took 834715us to `SubAndAssign` "cpus(r0):1;mem(r0):100; ... > cpus(r99):1;mem(r99):100" 10000 times. > [ OK ] > ResourcesOperators/Resources_BENCHMARK_Test.Operator_SubAndAssign/3 (835 ms) > [ RUN ] > ResourcesOperators/Resources_BENCHMARK_Test.Operator_SubAndAssign/4 > **Took 2.096096secs to `SubAndAssign` "[1-2, 4-5, ... , 298-299]" 10000 > times.** > [ OK ] > ResourcesOperators/Resources_BENCHMARK_Test.Operator_SubAndAssign/4 (2096 ms) > [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_CPUS/0 > Took 2750us to `cpus()` "cpus:1" 10000 times. > [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_CPUS/0 (3 > ms) > [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_CPUS/1 > Took 3223us to `cpus()` "cpus:1;mem:2" 10000 times. > [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_CPUS/1 (3 > ms) > [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_CPUS/2 > Took 102915us to `cpus()` "cpus(r0):1;cpus(r1):1; ... cpus(r99):1" 10000 > times. > [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_CPUS/2 (103 > ms) > [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_CPUS/3 > Took 131005us to `cpus()` "cpus(r0):1;mem(r0):100; ... > cpus(r99):1;mem(r99):100" 10000 times. > [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_CPUS/3 (131 > ms) > [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_CPUS/4 > Took 1408us to `cpus()` "[1-2, 4-5, ... , 298-299]" 10000 times. > [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_CPUS/4 (2 > ms) > [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_MEM/0 > Took 1453us to `mem()` "cpus:1" 10000 times. > [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_MEM/0 (1 ms) > [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_MEM/1 > Took 2968us to `mem()` "cpus:1;mem:2" 10000 times. > [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_MEM/1 (3 ms) > [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_MEM/2 > Took 28500us to `mem()` "cpus(r0):1;cpus(r1):1; ... cpus(r99):1" 10000 times. > [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_MEM/2 (29 > ms) > [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_MEM/3 > Took 134330us to `mem()` "cpus(r0):1;mem(r0):100; ... > cpus(r99):1;mem(r99):100" 10000 times. > [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_MEM/3 (135 > ms) > [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_MEM/4 > Took 1753us to `mem()` "[1-2, 4-5, ... , 298-299]" 10000 times. > [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_MEM/4 (1 ms) > [----------] 30 tests from ResourcesOperators/Resources_BENCHMARK_Test (52070 > ms total) > > > Thanks, > > Klaus Ma > >
