> On July 13, 2016, 1:32 p.m., Guangya Liu wrote: > > src/tests/containerizer/mesos_containerizer_tests.cpp, line 1104 > > <https://reviews.apache.org/r/47095/diff/5/?file=1384118#file1384118line1104> > > > > ```javascript > > EXPECT_TRUE(wait->has_status()); > > ```
All the other code in the tests use `wait.get()`, so i guess we better follow it here. > On July 13, 2016, 1:32 p.m., Guangya Liu wrote: > > src/tests/containerizer/provisioner_docker_tests.cpp, line 578 > > <https://reviews.apache.org/r/47095/diff/5/?file=1384119#file1384119line578> > > > > ```javascript > > SlaveID slaveId = slaveRegisteredMessage->slave_id(); > > ``` Again, all the other code in the tests use `slaveRegisteredMessage.get()`. - Shuai ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47095/#review142061 ----------------------------------------------------------- On May 14, 2016, 4:30 p.m., Shuai Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47095/ > ----------------------------------------------------------- > > (Updated May 14, 2016, 4:30 p.m.) > > > Review request for mesos, Guangya Liu and Jie Yu. > > > Bugs: MESOS-5312 > https://issues.apache.org/jira/browse/MESOS-5312 > > > Repository: mesos > > > Description > ------- > > Added tests for MESOS_SANDBOX env for unified containerizer. > > > Diffs > ----- > > src/tests/containerizer/mesos_containerizer_tests.cpp > 09742ff21513dc2570684d384b257868dd57a9ce > src/tests/containerizer/provisioner_docker_tests.cpp > 69505c922617273effc2eb52b0c567a3c01bf640 > > Diff: https://reviews.apache.org/r/47095/diff/ > > > Testing > ------- > > "make check" on ubuntu 14.04 64bit with gcc 4.8.4 > > > Thanks, > > Shuai Lin > >
