----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49943/#review142336 -----------------------------------------------------------
Ship it! Ship It! - Jiang Yan Xu On July 14, 2016, 8:14 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49943/ > ----------------------------------------------------------- > > (Updated July 14, 2016, 8:14 p.m.) > > > Review request for mesos, Benjamin Mahler, Jie Yu, and Jiang Yan Xu. > > > Repository: mesos > > > Description > ------- > > Updated HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave to > call vector reserve to reserve soem spaces before using, this can > help improve the performance of the test. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > 153c9b4cf4819e976910c5a7ad9602028e2d22eb > > Diff: https://reviews.apache.org/r/49943/diff/ > > > Testing > ------- > > make > make check > > ./bin/mesos-tests.sh --benchmark > --gtest_filter="SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/*" > [==========] Running 36 tests from 1 test case. > [----------] Global test environment set-up. > [----------] 36 tests from > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test > [ RUN ] > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/0 > Using 1000 agents and 1 frameworks > Added 1 frameworks in 102us > Added 1000 agents in 1.110443secs > Updated 1000 agents in 583296us > [ OK ] > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/0 > (1993 ms) > [ RUN ] > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/1 > Using 1000 agents and 50 frameworks > Added 50 frameworks in 1826us > Added 1000 agents in 2.577197secs > Updated 1000 agents in 2.412386secs > [ OK ] > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/1 > (5265 ms) > [ RUN ] > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/2 > Using 1000 agents and 100 frameworks > Added 100 frameworks in 4260us > Added 1000 agents in 4.275021secs > Updated 1000 agents in 3.902358secs > [ OK ] > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/2 > (8494 ms) > ... > > > Thanks, > > Guangya Liu > >
