----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50117/#review142611 -----------------------------------------------------------
Ship it! Nice patch, thanks! - Benjamin Mahler On July 18, 2016, 5:29 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50117/ > ----------------------------------------------------------- > > (Updated July 18, 2016, 5:29 a.m.) > > > Review request for mesos, Benjamin Mahler, Klaus Ma, and Jiang Yan Xu. > > > Repository: mesos > > > Description > ------- > > This patch is adding elapse time for addFramework, addSlave > and setQuota in allocator benchmark test, adding those elapse > time can help evaluate the performnace of those APIs. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > ce5da6be490b6fce311286eb4018c91eef55067e > > Diff: https://reviews.apache.org/r/50117/diff/ > > > Testing > ------- > > make > make check > > DeclineOffers benchmark > ``` > [==========] Running 1 test from 1 test case. > [----------] Global test environment set-up. > [----------] 1 test from > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test > [ RUN ] > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.DeclineOffers/1 > Using 1000 agents and 50 frameworks > Added 50 frameworks in 14779us > Added 1000 agents in 2.7833secs > round 0 allocate() took 2.325974secs to make 1000 offers > round 1 allocate() took 2.349536secs to make 1000 offers > round 2 allocate() took 2.368871secs to make 1000 offers > round 3 allocate() took 2.584638secs to make 1000 offers > ``` > > ResourceLabels benchmark > ``` > [==========] Running 1 test from 1 test case. > [----------] Global test environment set-up. > [----------] 1 test from > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test > [ RUN ] > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.ResourceLabels/1 > Using 1000 agents and 50 frameworks > Added 50 frameworks in 12574us > Added 1000 agents in 3.37232secs > round 0 allocate() took 2.459538secs to make 1000 offers > round 1 allocate() took 2.474587secs to make 1000 offers > ``` > > Mtrics benchmark > ``` > [==========] Running 1 test from 1 test case. > [----------] Global test environment set-up. > [----------] 1 test from > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test > [ RUN ] > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.Metrics/1 > Set quota for 50 roles in 64060us > Added 50 frameworks in 97191us > Added 1000 agents in 9.801111secs > /metrics/snapshot took 78252us for 1000 agents and 50 frameworks > [ OK ] > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.Metrics/1 (10055 > ms) > [----------] 1 test from > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test (10055 ms total) > > [----------] Global test environment tear-down > [==========] 1 test from 1 test case ran. (10079 ms total) > [ PASSED ] 1 test. > ``` > > > Thanks, > > Guangya Liu > >
