----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50163/ -----------------------------------------------------------
Review request for mesos, Joris Van Remoortere and Joseph Wu. Repository: mesos Description ------- This function accidentally assumed that 'data' will live beyond the scope of the call, by using 'data' within an asynchronous context. This copies the data into an 'evbuffer' which will then get moved into the output buffer in the event loop. Note that this does not introduce an additional copy: we still have a single copy to get 'data' into the bufferevent output buffer. AFAICT, this bug is currently not triggered from any of the calling code because each call-site deletes the 'data' after the Future completes (it appears that the 'send_callback' will be executed *after* the call to bufferevent_write and after the output buffer is flushed). Diffs ----- 3rdparty/libprocess/src/libevent_ssl_socket.cpp 2e7f33241b5291593cac4ea4c8f0351c19f7f0c2 Diff: https://reviews.apache.org/r/50163/diff/ Testing ------- make check Thanks, Benjamin Mahler
