> On July 18, 2016, 9:47 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 1465 > > <https://reviews.apache.org/r/50162/diff/1/?file=1446202#file1446202line1465> > > > > shouldn't we just do > > if (flags.etc_hosts_path.isSome()) { > > ..... > > } > > > > instead of having a separate check fo `flags.etc_hosts_path.isNone()` ?
Just to be consistent with below. This is easier to read IMO :) - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50162/#review142645 ----------------------------------------------------------- On July 18, 2016, 9:24 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50162/ > ----------------------------------------------------------- > > (Updated July 18, 2016, 9:24 p.m.) > > > Review request for mesos, Avinash sridharan and Qian Zhang. > > > Bugs: MESOS-5806 > https://issues.apache.org/jira/browse/MESOS-5806 > > > Repository: mesos > > > Description > ------- > > Ignored /etc/hosts if it does not exist in CNI isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > 81121a6a83fa9f62eea06a64ab96b1f564a63da8 > > Diff: https://reviews.apache.org/r/50162/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > >
