----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50172/#review142702 -----------------------------------------------------------
Patch looks great! Reviews applied: [50172] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On July 19, 2016, 3:35 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50172/ > ----------------------------------------------------------- > > (Updated July 19, 2016, 3:35 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > This patch added two new functions to sorter benchmark test to > generate a `ports` resource which falls into a specifed ports > range bounds. > > 1) fragment: Returns a "ports" resource with the number of ranges. > 2) makeRange: Returns the "ports" range bounds. > > > Diffs > ----- > > src/tests/sorter_tests.cpp b0e5ef8a55bbcca3553a221bd5691a9c801a04f7 > > Diff: https://reviews.apache.org/r/50172/diff/ > > > Testing > ------- > > ``` > ./bin/mesos-tests.sh --benchmark > --gtest_filter="AgentAndClientCount/Sorter_BENCHMARK_Test.FullSort/1" > [==========] Running 1 test from 1 test case. > [----------] Global test environment set-up. > [----------] 1 test from AgentAndClientCount/Sorter_BENCHMARK_Test > [ RUN ] AgentAndClientCount/Sorter_BENCHMARK_Test.FullSort/1 > Using 1000 agents and 50 clients > Added 50 clients in 872us > Added 1000 agents in 26457us > Added allocations for 1000 agents in 79697us > Full sort of 50 clients took 1321us > No-op sort of 50 clients took 28us > [ OK ] AgentAndClientCount/Sorter_BENCHMARK_Test.FullSort/1 (115 ms) > [----------] 1 test from AgentAndClientCount/Sorter_BENCHMARK_Test (115 ms > total) > > [----------] Global test environment tear-down > [==========] 1 test from 1 test case ran. (133 ms total) > [ PASSED ] 1 test. > ``` > > > Thanks, > > Guangya Liu > >
