-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50205/
-----------------------------------------------------------
Review request for mesos, Klaus Ma and Jiang Yan Xu.
Bugs: MESOS-4892
https://issues.apache.org/jira/browse/MESOS-4892
Repository: mesos
Description
-------
Enhanced benchmark test for resources to include shared resources.
Diffs
-----
src/tests/resources_tests.cpp 4111e080b84079e100b731c9a56861b204f17388
Diff: https://reviews.apache.org/r/50205/diff/
Testing
-------
Tests passed. Results for resources benchmark is as follows:
Minimal impact seen in Resources arithmetic with the Resources refactor changes
to incorporate shared resources.
With shared resources patch (note that 4th test below is for shared resources
for scalars)
[----------] 4 tests from ResourcesOperators/Resources_BENCHMARK_Test
[ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/0
[ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/0 (964 ms)
[ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/1
[ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/1 (17099 ms)
[ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2
[ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2 (9222 ms)
[ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/3
[ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/3 (1049 ms)
[----------] 4 tests from ResourcesOperators/Resources_BENCHMARK_Test (28334 ms
total)
HEAD
[----------] 3 tests from ResourcesOperators/Resources_BENCHMARK_Test
[ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/0
[ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/0 (866 ms)
[ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/1
[ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/1 (17563 ms)
[ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2
[ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2 (9218 ms)
[----------] 3 tests from ResourcesOperators/Resources_BENCHMARK_Test (27647 ms
total)
Output from stdout is:
[==========] Running 4 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 4 tests from ResourcesOperators/Resources_BENCHMARK_Test
[ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/0
Took 113429us to perform 50000 'total += r' operations on cpus(*):1; gpus(*):1;
mem(*):128; disk(*):256
Took 154104us to perform 50000 'total -= r' operations on cpus(*):1; gpus(*):1;
mem(*):128; disk(*):256
Took 327479us to perform 50000 'total = total + r' operations on cpus(*):1;
gpus(*):1; mem(*):128; disk(*):256
Took 365752us to perform 50000 'total = total - r' operations on cpus(*):1;
gpus(*):1; mem(*):128; disk(*):256
[ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/0 (964 ms)
[ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/1
Took 4.105799secs to perform 10 'total += r' operations on cpus(0, principal_0,
{key_0: value_0}):1; gpus(...
Took 4.325702secs to perform 10 'total -= r' operations on cpus(0, principal_0,
{key_0: value_0}):1; gpus(...
Took 4.188394secs to perform 10 'total = total + r' operations on cpus(0,
principal_0, {key_0: value_0}):1; gpus(...
Took 4.428872secs to perform 10 'total = total - r' operations on cpus(0,
principal_0, {key_0: value_0}):1; gpus(...
[ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/1 (17099 ms)
[ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2
Took 2.515553secs to perform 1000 'total += r' operations on ports(*):[1-2,
4-5, 7-8, 10-11, 13-14, 16-17, 1...
Took 2.038598secs to perform 1000 'total -= r' operations on ports(*):[1-2,
4-5, 7-8, 10-11, 13-14, 16-17, 1...
Took 2.62789secs to perform 1000 'total = total + r' operations on
ports(*):[1-2, 4-5, 7-8, 10-11, 13-14, 16-17, 1...
Took 2.03868secs to perform 1000 'total = total - r' operations on
ports(*):[1-2, 4-5, 7-8, 10-11, 13-14, 16-17, 1...
[ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2 (9222 ms)
[ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/3
Took 102441us to perform 50000 'total += r' operations on cpus(*):1;
mem(*):128; disk(test)[persistentId:...
Took 141011us to perform 50000 'total -= r' operations on cpus(*):1;
mem(*):128; disk(test)[persistentId:...
Took 383887us to perform 50000 'total = total + r' operations on cpus(*):1;
mem(*):128; disk(test)[persistentId:...
Took 421132us to perform 50000 'total = total - r' operations on cpus(*):1;
mem(*):128; disk(test)[persistentId:...
[ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/3 (1049 ms)
[----------] 4 tests from ResourcesOperators/Resources_BENCHMARK_Test (28334 ms
total)
[----------] Global test environment tear-down
[==========] 4 tests from 1 test case ran. (28353 ms total)
[ PASSED ] 4 tests.
Thanks,
Anindya Sinha
