----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45959/#review142892 -----------------------------------------------------------
include/mesos/resources.hpp (line 84) <https://reviews.apache.org/r/45959/#comment208553> I think this's dangous, the developer need to check this converting and decide which `operator` is used. If miss used, it's hard to debuging. include/mesos/resources.hpp (line 124) <https://reviews.apache.org/r/45959/#comment208558> Seems `Option` is not necessary. include/mesos/resources.hpp (line 479) <https://reviews.apache.org/r/45959/#comment208554> Why not `list`? It may avoid un-necessary resizing. src/common/resources.cpp (lines 308 - 316) <https://reviews.apache.org/r/45959/#comment208555> I think we can check name,type, role firstly, then check SharedInfo. src/common/resources.cpp (line 882) <https://reviews.apache.org/r/45959/#comment208557> one `isShared()` is enough. `isShared` is checked in `subtractable`. - Klaus Ma On July 20, 2016, 6:51 a.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45959/ > ----------------------------------------------------------- > > (Updated July 20, 2016, 6:51 a.m.) > > > Review request for mesos, Benjamin Mahler, Joris Van Remoortere, and Jiang > Yan Xu. > > > Bugs: MESOS-4892 > https://issues.apache.org/jira/browse/MESOS-4892 > > > Repository: mesos > > > Description > ------- > > A new class Resource_ is added that allows 'Resources' to group > identical shared resource objects together into a single 'Resource_' > object and tracked by its shared count. Non-shared resource objects > are not grouped. > > For resource addition and subtraction, the shared count is adjusted for > shared resources as follows: > a) Addition: If shared resource is absent from original, then the > resource is added initialized with a consumer count of 1. Otherwise, > the share count for the shared resource is incremented. > b) Subtraction: If shared resource's share count is already 1, then > the shared resource is removed from the original. Otherwise, its > consumer count is decremented. > > Note that v1 changes for shared resources are in the next commit. > > > Diffs > ----- > > include/mesos/resources.hpp a557e97c65194d4aad879fb88d8edefd1c95b8d8 > src/common/resources.cpp b1bd2784aefdebf91892638b40b215373b998574 > src/master/validation.cpp 50ba372d1301d16d1738a3e4f4882b51f9ce06cd > src/tests/mesos.hpp e4eccfc3810bed3649a3ab80e252849470de4c72 > src/tests/resources_tests.cpp 4111e080b84079e100b731c9a56861b204f17388 > > Diff: https://reviews.apache.org/r/45959/diff/ > > > Testing > ------- > > New tests added to demonstrate arithmetic operations for shared resources > with consumer counts. > Tests successful. > > > Thanks, > > Anindya Sinha > >
