----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50208/#review142918 -----------------------------------------------------------
Patch looks great! Reviews applied: [50184, 50208] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On July 20, 2016, 1:45 a.m., zhou xing wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50208/ > ----------------------------------------------------------- > > (Updated July 20, 2016, 1:45 a.m.) > > > Review request for mesos and Anand Mazumdar. > > > Bugs: mesos-5867 > https://issues.apache.org/jira/browse/mesos-5867 > > > Repository: mesos > > > Description > ------- > > There are two early returns without closing the file > when using read_file operator API. The two returns are: > > - when `length=0` > - when finishes reading file > > > Diffs > ----- > > src/files/files.cpp 8ab8f8aad9cfe1e536b29e8994fcd8599627e590 > > Diff: https://reviews.apache.org/r/50208/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > zhou xing > >
