----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50177/#review142968 -----------------------------------------------------------
Overall it LGTM. configure.ac (line 615) <https://reviews.apache.org/r/50177/#comment208618> This doesn't read correctly and it sort of states the obvious, consider simplying it: # Check for systemd and link it in if present. src/linux/systemd.cpp (lines 198 - 200) <https://reviews.apache.org/r/50177/#comment208621> The terminology here is a little confusing. The 'watchdog daemon' is the process running this function, and we're not pinging the watchdog we're sending a message to systemd. Consider rewording, eg: // If the WATCHDOG_USEC environment variable is set systemd expects a watchdog message every WATCHDOG_USEC / 2 microseconds. The message indicates liveliness to systemd. - David Robinson On July 19, 2016, 1:14 a.m., Lawrence Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50177/ > ----------------------------------------------------------- > > (Updated July 19, 2016, 1:14 a.m.) > > > Review request for mesos, David Robinson and Ian Downes. > > > Repository: mesos > > > Description > ------- > > Adds systemd watchdog support (see > http://0pointer.de/blog/projects/watchdog.html for context). > > > Diffs > ----- > > configure.ac d2136909b7305498ae901a5ea00133142b77f9e6 > src/linux/systemd.hpp 91134f1d4b100759e45931bd09ca4e1e1aeaaf8a > src/linux/systemd.cpp 619aa2778da5f99d3a078a8e1208bdaa9dc77581 > src/slave/main.cpp 4624392d30cf391015dcd63f447fe2414a47a16a > > Diff: https://reviews.apache.org/r/50177/diff/ > > > Testing > ------- > > Tested by sending SIGSTOP to running mesos and verifying via journalctl that > it was killed by the watchdog. > > TODO: write actual test by using and forking a mock binary that initializes > systemd and sending SIGSTOP to that binary. test also needs a unit file for > that binary and for systemd to run so we can verify that systemd killed it. > > > File Attachments > ---------------- > > mesos gets owned by watchdog > > https://reviews.apache.org/media/uploaded/files/2016/07/19/3c73b595-d28e-45d4-adfe-697801ba02cc__Screen_Shot_2016-07-18_at_2.09.31_PM.png > > > Thanks, > > Lawrence Wu > >
