----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50223/#review142977 -----------------------------------------------------------
src/master/flags.cpp (lines 225 - 226) <https://reviews.apache.org/r/50223/#comment208630> Enclose the flag names in backticks src/master/flags.cpp (line 238) <https://reviews.apache.org/r/50223/#comment208631> Do we really want `--authenticate_http` to be an alias for the readonly flag as well? Since `--authenticate_http` only covered the readwrite endpoints in 0.28, perhaps we should only use the alias for the readwrite flag. src/master/main.cpp (line 278) <https://reviews.apache.org/r/50223/#comment208633> I think here, I would advocate extending the READONLY/READWRITE distinction to libprocess as well. `libprocess::initialize` could accept two realms, one for readonly endpoints and the other for readwrite. src/master/master.hpp (line 1895) <https://reviews.apache.org/r/50223/#comment208634> Can we use `string&` here instead of `const char*`? src/master/master.cpp (lines 418 - 420) <https://reviews.apache.org/r/50223/#comment208635> Fits on one line? src/tests/cluster.hpp (line 105) <https://reviews.apache.org/r/50223/#comment208636> The `/files/*` endpoints should belong to the readonly realm, right? - Greg Mann On July 20, 2016, 3:21 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50223/ > ----------------------------------------------------------- > > (Updated July 20, 2016, 3:21 p.m.) > > > Review request for mesos, Adam B, Benjamin Bannier, Greg Mann, and Till > Toenshoff. > > > Bugs: MESOS-5851 > https://issues.apache.org/jira/browse/MESOS-5851 > > > Repository: mesos > > > Description > ------- > > Changes included: > - separate flags for readonly and readwrite endpoints; > - helper function for registering http authenticator; > - fixing existing tests. > > Open question: > - location and name of helper function. > > Next step: > - test for readonly endpoints; > - similar change to agent endpoints; > - docs/configuration.md fix; > - docs/endpoints/index.md fix. > > > Diffs > ----- > > src/local/local.cpp a543aef117fea62660d55435be4d66d30f8ee860 > src/master/constants.hpp 410c388c8f8ad98777c6587fc0b06807639e782a > src/master/flags.hpp a5dd11b624d19a9ea3508031ded4c0199098afd1 > src/master/flags.cpp ca3e80bf9467328892be89718e5e0a1a05264ab8 > src/master/main.cpp 9775b8a1e5fe51670789805557339bd0737a02b7 > src/master/master.hpp 6decff6f4b9c3434de030fd5c06df4c683a7abad > src/master/master.cpp 370fd8712062dc75bb81824cb99ccc7920acbf78 > src/tests/cluster.hpp 55dbaaef6c703676859e39e50bb1c31b942d0929 > src/tests/cluster.cpp e1be275fccf130181ed18fd1c5a1b7b18979d7aa > src/tests/dynamic_weights_tests.cpp > 6aa0102d3821c1b9d09672c706d6d8850f3729c3 > src/tests/master_quota_tests.cpp 639f4c4146c61c0713e2945fea4fd6ffe1f3e726 > src/tests/mesos.cpp d073d79c5797ecb021f0294ab6586a000f3ca600 > src/tests/persistent_volume_endpoints_tests.cpp > fdd10a76dbfaf8bcae021b9d8b976f43748117fe > src/tests/reservation_endpoints_tests.cpp > 48c002d1dc371c285b9421ef5a2c57250d270fa8 > > Diff: https://reviews.apache.org/r/50223/diff/ > > > Testing > ------- > > `make check` on Mac OS. > > > Thanks, > > Zhitao Li > >
