> On July 20, 2016, 10:38 p.m., Jie Yu wrote: > > src/launcher/fetcher.cpp, lines 513-514 > > <https://reviews.apache.org/r/50200/diff/3/?file=1448382#file1448382line513> > > > > ``` > > CHECK_SOME(os::su(...)) > > << ... > > ``` > > > > BTW, no idea why we use CHECK_SOME here. Looks to me that we should > > check the error and `return EXIT_FAILURE` here. Can you follow up with a > > patch to fix all occurance of CHECK_SOME here?
I fixed the instances of CHECK_SOME in my patches, and I'll leave a link here shortly to a patch replacing the remaining occurrences. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50200/#review143022 ----------------------------------------------------------- On July 20, 2016, 11:02 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50200/ > ----------------------------------------------------------- > > (Updated July 20, 2016, 11:02 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Joerg Schad. > > > Bugs: mesos-5845 > https://issues.apache.org/jira/browse/mesos-5845 > > > Repository: mesos > > > Description > ------- > > To ensure that a task cannot fetch root-protected > files from the local filesystem when running as a > non-root user, this patch changes the fetcher to > fetch files as the task user. > > > Diffs > ----- > > src/launcher/fetcher.cpp 0539b0182bd4a7178f103dddd1ab4fee8fc79eda > src/tests/fetcher_tests.cpp d38ce6e750dc828ef5af4a27fac76327cc4cb56c > > Diff: https://reviews.apache.org/r/50200/diff/ > > > Testing > ------- > > A new test was added to the fetcher tests: > `FetcherTest.ROOT_RootProtectedFileURI`. > > `sudo make check` was used to test on both OSX and CentOS 7. > > Note that two of the fetcher tests fail for me when run as root on OSX. I saw > the following on my OSX 10.10.5 system: > ``` > [ FAILED ] FetcherCacheTest.LocalUncachedExtract > [ FAILED ] FetcherCacheHttpTest.HttpMixed > ``` > > These failures are already tracked here: > https://issues.apache.org/jira/browse/MESOS-4890 > > > Thanks, > > Greg Mann > >
