----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50261/#review143026 -----------------------------------------------------------
Ship it! Nice cleanup, thanks for following up on my email even though this isn't your code! src/tests/hierarchical_allocator_tests.cpp (line 3518) <https://reviews.apache.org/r/50261/#comment208702> Perhaps createLabels instead of makeLabels to be consistent with the existing createLabel naming? - Benjamin Mahler On July 20, 2016, 9:10 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50261/ > ----------------------------------------------------------- > > (Updated July 20, 2016, 9:10 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Updated allocator test helper function `makeLabels` more readable. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > 3ddce7ab19613831527f010524b8454fecfb9927 > > Diff: https://reviews.apache.org/r/50261/diff/ > > > Testing > ------- > > Discussion for this: http://markmail.org/thread/7sjfbfxi7tkhu35p > > make > make check > > ``` > [==========] Running 1 test from 1 test case. > [----------] Global test environment set-up. > [----------] 1 test from > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test > [ RUN ] > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.ResourceLabels/1 > Using 1000 agents and 50 frameworks > Added 50 frameworks in 10012us > Added 1000 agents in 3.337114secs > round 0 allocate() took 2.498978secs to make 1000 offers > round 1 allocate() took 2.459849secs to make 1000 offers > round 2 allocate() took 2.434381secs to make 1000 offers > round 3 allocate() took 2.488205secs to make 1000 offers > round 4 allocate() took 2.479436secs to make 1000 offers > ``` > > > Thanks, > > Guangya Liu > >
