----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50277/#review143051 -----------------------------------------------------------
3rdparty/libprocess/include/process/process.hpp (lines 486 - 488) <https://reviews.apache.org/r/50277/#comment208744> Be consistent with either "read-write" or "readwrite". 3rdparty/libprocess/src/tests/main.cpp (lines 54 - 56) <https://reviews.apache.org/r/50277/#comment208795> I think this case is slightly ambiguous, but in general we prefer the style: ``` process::initialize( None(), process::READWRITE_HTTP_AUTHENTICATION_REALM, process::READONLY_HTTP_AUTHENTICATION_REALM); ``` See "Indentation" in http://mesos.apache.org/documentation/latest/c++-style-guide/ - Greg Mann On July 21, 2016, 1:25 a.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50277/ > ----------------------------------------------------------- > > (Updated July 21, 2016, 1:25 a.m.) > > > Review request for mesos, Adam B, Benjamin Bannier, Greg Mann, and Till > Toenshoff. > > > Bugs: MESOS-5851 > https://issues.apache.org/jira/browse/MESOS-5851 > > > Repository: mesos > > > Description > ------- > > Separate readonly and readwrite realms in libprocess. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/gtest.hpp > 21f66edf0b8c8a20fb4497b1a66dcdde5c328148 > 3rdparty/libprocess/include/process/process.hpp > 2e85d315aa479477bf0ac000e617761c8aa43f9e > 3rdparty/libprocess/src/process.cpp > c20a72b74b9b4d4729d83d2a5a162529fa35d682 > 3rdparty/libprocess/src/tests/main.cpp > a03dbc4ab46747003d8b11d22f2dc136293264ec > 3rdparty/libprocess/src/tests/metrics_tests.cpp > d4d99de6d3bd9249e7b65e6be5841fbdb670a744 > 3rdparty/libprocess/src/tests/profiler_tests.cpp > bf7a37536a7d15a03d1a88258f8cfb1f4b56bce8 > > Diff: https://reviews.apache.org/r/50277/diff/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
