----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50320/#review143198 -----------------------------------------------------------
Fix it, then Ship it! I'll fix these nits and commit all 3, then address Greg's doc updates. src/common/http.hpp (line 167) <https://reviews.apache.org/r/50320/#comment208993> Nit: should be double-blank line between top-scoped functions. src/common/http.hpp (line 182) <https://reviews.apache.org/r/50320/#comment208994> This is called 'credentials' in the doxygen and the cpp - Adam B On July 22, 2016, 12:55 a.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50320/ > ----------------------------------------------------------- > > (Updated July 22, 2016, 12:55 a.m.) > > > Review request for mesos, Adam B and Greg Mann. > > > Bugs: MESOS-5851 > https://issues.apache.org/jira/browse/MESOS-5851 > > > Repository: mesos > > > Description > ------- > > Refactor common HTTP authenticator initialize into helper function. > > > Diffs > ----- > > src/common/http.hpp 2dfa789d475598f07a5123899025937fd145a3da > src/common/http.cpp d73170df4e35b84d194347406b3061236de6f7be > src/master/constants.hpp 410c388c8f8ad98777c6587fc0b06807639e782a > src/master/flags.cpp ca3e80bf9467328892be89718e5e0a1a05264ab8 > src/master/master.hpp 6decff6f4b9c3434de030fd5c06df4c683a7abad > src/master/master.cpp 370fd8712062dc75bb81824cb99ccc7920acbf78 > src/slave/constants.hpp 10319396a6694e17137876b95ac6866c3d2ebcbd > src/slave/flags.cpp 166a6516362a23bc5012aaa2dd45edfc6446de48 > src/slave/slave.hpp ffe4220c9289419ab1b1a2c1f499b6eac3c01e4b > src/slave/slave.cpp 3e7131170e1f9bf682fb0c603d2ca39f514d87d9 > > Diff: https://reviews.apache.org/r/50320/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Zhitao Li > >
