----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50357/#review143279 -----------------------------------------------------------
src/linux/ns.hpp <https://reviews.apache.org/r/50357/#comment209058> SO We don't need this because this is a no-op? https://github.com/apache/mesos/blob/4f26c7d8dbd0702c7dcd8023717636d5dcc2f90e/3rdparty/stout/include/stout/os/open.hpp#L30 The above seems to be defining O_CLOEXEC, even on older systems that don't have them and explicitly calling `cloexec` on the `fd`. - Avinash sridharan On July 22, 2016, 9:17 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50357/ > ----------------------------------------------------------- > > (Updated July 22, 2016, 9:17 p.m.) > > > Review request for mesos, Avinash sridharan, Gilbert Song, Artem Harutyunyan, > Ian Downes, and Jie Yu. > > > Repository: mesos > > > Description > ------- > > The call to `os::open` that creates the FD includes O_CLOEXEC. > This will set CLOEXEC on the FD before `os::open` returns. > > > Diffs > ----- > > src/linux/ns.hpp 4e843b7835f44418b79a0b38e3d66aa30e68f700 > > Diff: https://reviews.apache.org/r/50357/diff/ > > > Testing > ------- > > make check (CentOS 7) > > > Thanks, > > Joseph Wu > >
