> On July 12, 2016, 9:40 p.m., Alex Clemmer wrote: > > support/windows-build.bat, line 44 > > <https://reviews.apache.org/r/49926/diff/1/?file=1441664#file1441664line44> > > > > Heh. Do we want to actually explain that this is a bug? This comment > > seems more like an inside joke right now. :) > > Joseph Wu wrote: > I'm not clear whether this is a bug or not. We definitely want to > explain why we're passing the option though. > > And AFAICT, specifying the `PreferredToolArchitecture` only changes the > build time (by a lot). I don't think it changes the behavior of the > executables.
Yes. I have confirmed this is a bug in the linker. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49926/#review141965 ----------------------------------------------------------- On July 12, 2016, 11:16 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49926/ > ----------------------------------------------------------- > > (Updated July 12, 2016, 11:16 p.m.) > > > Review request for mesos, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, and > Vinod Kone. > > > Bugs: MESOS-5822 > https://issues.apache.org/jira/browse/MESOS-5822 > > > Repository: mesos > > > Description > ------- > > This adds a script that will be run on the ASF CI, similar to how the > `docker_build.sh` script is used for the existing Linux-based CI. > > This Jenkins job for Mesos on Windows can be found here: > https://builds.apache.org/job/Mesos-Windows/ > > > Diffs > ----- > > support/windows-build.bat PRE-CREATION > > Diff: https://reviews.apache.org/r/49926/diff/ > > > Testing > ------- > > Pointed the Jenkins job at my local branch and triggered the build. > > This is what Jenkins is running: > ``` > :: Run a script provided by Visual Studio which sets up a > :: couple environment variables needed by the build. > CALL "F:/Microsoft/Visual Studio CE 2015/VC/vcvarsall.bat" > > @echo on > > :: Recreate the `/tmp` directory needed by tests. > RMDIR /q /s %CD:~0,3%tmp > MKDIR %CD:~0,3%tmp > if %errorlevel% neq 0 exit /b %errorlevel% > > :: We need to specify the path to GNU Patch, > :: since it is installed in a non-default location. > SET OTHER_CMAKE_OPTIONS=-DPATCHEXE_PATH="F:/Program Files (x86)/GnuWin32/bin" > > :: Call the Windows build script. > "support/windows-build.bat" > ``` > > > Thanks, > > Joseph Wu > >
