> On July 27, 2016, 5:49 a.m., Jiang Yan Xu wrote: > > src/master/http.cpp, line 2038 > > <https://reviews.apache.org/r/50482/diff/2/?file=1454730#file1454730line2038> > > > > Is `request.url.path == stringify(request.url)` guaranteed? Even if it > > is, would `request.url.path` be more explicit?
Besides url path, we include the query and fragment in URL as well. For example, if our request is `master/state?JSONP_CALLBACK=a#test`, then the redirect path would become `master/state`. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50482/#review143677 ----------------------------------------------------------- On July 27, 2016, 3:41 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50482/ > ----------------------------------------------------------- > > (Updated July 27, 2016, 3:41 a.m.) > > > Review request for mesos, Adam B, Jie Yu, Vinod Kone, and Jiang Yan Xu. > > > Bugs: MESOS-5911 > https://issues.apache.org/jira/browse/MESOS-5911 > > > Repository: mesos > > > Description > ------- > > Fixed the CORS error when redirect in webui. > > > Diffs > ----- > > src/master/http.cpp 1cbec976ccedae81def388c62889624aaf9a794e > src/webui/master/static/js/controllers.js > ceaf1402ebdae4efd1a8a6fc9c7b795de69e2fc0 > > Diff: https://reviews.apache.org/r/50482/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
