----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/#review143692 -----------------------------------------------------------
src/slave/containerizer/docker.cpp (line 176) <https://reviews.apache.org/r/50123/#comment209592> s/.get()/-> src/slave/containerizer/docker.cpp (line 184) <https://reviews.apache.org/r/50123/#comment209591> kill this as the default value is already `None()` src/slave/containerizer/docker.cpp (line 349) <https://reviews.apache.org/r/50123/#comment209594> Why do you add the comment here? This flag does not seems to related to gpu. src/slave/containerizer/docker.cpp (line 1239) <https://reviews.apache.org/r/50123/#comment209596> Line 1248 already clarified `no devices` here, still need your comment? src/slave/containerizer/docker.cpp (lines 1305 - 1311) <https://reviews.apache.org/r/50123/#comment209598> Please adjust the format as following: ``` // Allocate GPUs according to task resources. const Option<TaskInfo>& taskInfo = container->task; if (!taskInfo.isSome()) { return Failure("No task information found"); } ``` src/slave/containerizer/docker.cpp (line 1357) <https://reviews.apache.org/r/50123/#comment209600> Seems no one is using `nvidiaGpus`? It should be set as parameter for `--device` when running container. src/slave/containerizer/docker.cpp (lines 1550 - 1561) <https://reviews.apache.org/r/50123/#comment209601> Why release the gpu resources here? The `update` will also be called when the executor is launched. - Guangya Liu On 七月 18, 2016, 9:17 a.m., Yubo Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50123/ > ----------------------------------------------------------- > > (Updated 七月 18, 2016, 9:17 a.m.) > > > Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. > > > Bugs: MESOS-5795 > https://issues.apache.org/jira/browse/MESOS-5795 > > > Repository: mesos > > > Description > ------- > > This added 'NvidiaGpuAllocator' to docker containerizer so that the > docker containerizer can use it to allocate GPUs to the task with 'gpus' > resource. Also, allocated GPUs will automatically deallocated after the > job destroyed. > > > Diffs > ----- > > src/slave/containerizer/docker.hpp 43ca4317d608b3b43dd7bd0d1b55c721e7364885 > src/slave/containerizer/docker.cpp f1ecf3b25d85597f6c3dcaa47968860ed119dbd5 > > Diff: https://reviews.apache.org/r/50123/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Yubo Li > >
